bazelbuild / rules_jsonnet

Jsonnet rules for Bazel
https://bazelbuild.github.io/rules_jsonnet/
Apache License 2.0
68 stars 73 forks source link

Change name of @jsonnet_go external reference to @google_jsonnet_go. #145

Closed mishas closed 2 years ago

mishas commented 2 years ago

The repository at https://github.com/google/go-jsonnet has a WORKSPACE file with workspace(name = "google_jsonnet_go") header.

Based on Bazel's recommendations, the external repository's name (http_archive's or git_repository's name= argument) should match the workspace name. This will make it easier to make sure that a project that depends both on go-jsonnet and rules_jsonnet will only have 1 version of the go-jsonnet binaries in play.

Also moved to using http_archive (rather than git_repository) to be in line with best practices.

mishas commented 2 years ago

Hello @Globegitter , @sparkprime ,

Any chance to get a review for this please?

Also - would it be possible to get a new release once this is merged? (It'll include this, but also #143 which adds new features)

Thank you very much!

mishas commented 2 years ago

@Globegitter , @sparkprime , friendly ping on that please?

Thank you.

mishas commented 2 years ago

@Globegitter, @sparkprime , weekly friend ping?

Thanks.

mishas commented 2 years ago

Hello @Globegitter and @sparkprime ,

Any chance this can be reviewed anytime soon?

Thank you.

mishas commented 2 years ago

Hello @Globegitter and @sparkprime ,

Friendly ping?

sparkprime commented 2 years ago

Thanks Misha

mishas commented 2 years ago

Thank you @sparkprime for merging!

Can I also ask you to review/merge #147 or #148 (they're both the same) - it'll fix rules_jsonnet to work in the upcoming Bazel5?

Also - if there's anything I can do to help with this project, please let me know.

Thanks again!