search

bazelbuild / rules_jvm_external

Bazel rules to resolve, fetch and export Maven artifacts
Apache License 2.0
317 stars 241 forks source link

mvn can resolve some circular dependency conflicts #759

Open aryeh-looker opened 1 year ago

aryeh-looker commented 1 year ago

Repro and differences: https://github.com/aryeh-looker/bazel-circular-deps

Perhaps the rules could be modified to automatically resolve circular dependency conflicts when presented or documentation could be added to the repro and to error messages.

aryeh-looker commented 1 year ago

Related: https://github.com/powsybl/powsybl-core/issues/2300

jin commented 1 year ago

How does maven ensure that it's safe to ignore the circular dep? Until we follow the same algorithm, I think making this a feature of RJE might lead to hard-to-debug failures that is better off dealt with a fail-fast cyclic dep error.