search

bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
291 stars 136 forks source link

Resolver library #628

Closed mariusgrigoriu closed 3 years ago

mariusgrigoriu commented 3 years ago

There are times you may want a custom resolver, but not re-implement all of the behavior that exists in the one provided by rules_k8s. You could chain resolvers by executing the one from rules_k8s, but it would be nice if you could import it as a go package.

This PR moves the resolver into a library that custom Go resolvers can easily reuse to register flags and then pass execution to the rules_k8s resolver after performing custom processing.

k8s-ci-robot commented 3 years ago

Hi @mariusgrigoriu. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chases2 commented 3 years ago

/ok-to-test This looks like a fine refactoring to me, but I'd like another set of eyes on this. /assign @fejta

fejta commented 3 years ago

/test all

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mariusgrigoriu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)~~ [fejta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment