bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
290 stars 137 forks source link

Support M1 #683

Closed rajatvig closed 2 years ago

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajatvig To complete the pull request process, please assign fejta after the PR has been reviewed. You can assign the PR to them by writing /assign @fejta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 years ago

Hi @rajatvig. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta commented 2 years ago

/ok-to-test

fejta commented 2 years ago

/retest

fejta commented 2 years ago

I suspect we'll need to wait for various caches to become consistent again.

rajatvig commented 2 years ago

I suspect we'll need to wait for various caches to become consistent again.

Very likely but unsure. To test, just downloaded the archive and it has the new SHA. Ran a clean bazel build with a local patch for it and that too used the new SHA.

moriarty commented 2 years ago

I suspect we'll need to wait for various caches to become consistent again.

Very likely but unsure. To test, just downloaded the archive and it has the new SHA. Ran a clean bazel build with a local patch for it and that too used the new SHA.

while true; do curl --silent -L https://github.com/yaml/pyyaml/archive/5.1.2.zip | shasum -a 256; sleep 2; done

Try that and see if you get consistent results. It seems to vary based on location and ISP... hopefully it trickles through all the various CDNs

fejta commented 2 years ago

/retest

rajatvig commented 2 years ago

/retest

rajatvig commented 2 years ago

@fejta From what it looks like, most caches have now got it fixed.

rajatvig commented 2 years ago

/retest

fejta commented 2 years ago

Can you drop the last two commits from this PR? (alternatively click rebuild on buildkite to rerun the build)

rajatvig commented 2 years ago

@fejta Dropped the two commits but I do not have rights to rebuild

rajatvig commented 2 years ago

/retest

rajatvig commented 2 years ago

@fejta Could you retrigger the tests?

rajatvig commented 2 years ago

/retest

rajatvig commented 2 years ago

/retest-required

k8s-ci-robot commented 2 years ago

@rajatvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-rules-k8s-e2e 485b4d3dfaa88a1e2ccc714d983bb996a7551569 link true /test pull-rules-k8s-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fejta commented 2 years ago

Mostly superseded by https://github.com/bazelbuild/rules_k8s/pull/697