search

bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
291 stars 136 forks source link

`@platforms` should be explicitly imported #686

Open chases2 opened 2 years ago

chases2 commented 2 years ago

https://github.com/bazelbuild/rules_k8s/pull/675 moved us from @bazel_tools/platforms to @platforms. Thanks!

The deprecation issue (https://github.com/bazelbuild/bazel/issues/8622) indicates we should explicitly import @platforms instead of relying on the "snapshot" built in. I don't think we're doing that anywhere; it's not in our WORKSPACE, at least.

A git repository rule should do the trick. This is likely low-priority; I don't see a timeline for removing the snapshot.

meteorcloudy commented 2 years ago

Adding a http_archive would do:

http_archive(
    name = "platforms",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/platforms/releases/download/0.0.5/platforms-0.0.5.tar.gz",
        "https://github.com/bazelbuild/platforms/releases/download/0.0.5/platforms-0.0.5.tar.gz",
    ],
    sha256 = "379113459b0feaf6bfbb584a91874c065078aa673222846ac765f86661c27407",
)

Currently, the @platform repository is made available with WORKSPACE suffix by Bazel, but yes, eventually every project should specify it explicitly.

Note that we're also migrating to a new external dependency system for Bazel, see https://bazel.build/docs/bzlmod