search

bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
291 stars 136 forks source link

Added toolchain support for Apple M1 and made toolchain_type public to allow extensions #697

Closed lomeshpatel closed 2 years ago

lomeshpatel commented 2 years ago
  1. Added and registered kubectl_macos_arm64_toolchain
  2. Changed the name of kubectl_osx_toolchain to kubectl_macos_x86_64_toolchain and added an alias for backwards compatibility. Also updated the registration.
  3. Made toolchain/kubectl package public to allow for extensions for this toolchain_type

696

k8s-ci-robot commented 2 years ago

Hi @lomeshpatel. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta commented 2 years ago

/ok-to-test

k8s-ci-robot commented 2 years ago

@lomeshpatel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-rules-k8s-e2e 833f4bef0c8043446dc839678c6312435b7b66bc link true /test pull-rules-k8s-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, lomeshpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)~~ [fejta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lomeshpatel commented 2 years ago

@fejta I noticed that one of the checks failed, is that expected or do I need to fix something?

Also, can you please point me to the release process? I just would like to have some understanding of when these changes will be available.