search

bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
290 stars 137 forks source link

Add ParseTagOption to k8s/go/pkg/resolver #698

Closed gonzojive closed 2 years ago

k8s-ci-robot commented 2 years ago

Hi @gonzojive. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta commented 2 years ago

/test all

fejta commented 2 years ago

Can you please get this to pass tests?

gonzojive commented 2 years ago

Can you please get this to pass tests?

Done.

fejta commented 2 years ago

/ok-to-test

fejta commented 2 years ago

PS: mostly trying to better understand the need here (aka make it easier to configure if an image is secure) and why this is a good approach for addressing that need.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, gonzojive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)~~ [fejta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment