bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
290 stars 136 forks source link

Update dependencies #715

Closed Vertexwahn closed 1 year ago

Vertexwahn commented 1 year ago

This PR updates a few dependencies (bazel_skylib and rules_docker)

k8s-ci-robot commented 1 year ago

Hi @Vertexwahn. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chases2 commented 1 year ago

/ok-to-test

Vertexwahn commented 1 year ago

/retest

chases2 commented 1 year ago

Looks good overall; please squash your commits together since the intermediate steps don't pass tests. /assign

Vertexwahn commented 1 year ago

@chases2 I squashed the commits

chases2 commented 1 year ago

Thanks! /approve /lgtm

Vertexwahn commented 1 year ago

@chases2 Would expect that this PR merges now automatically - but nothing happens - any idea?

Vertexwahn commented 1 year ago

@fejta Can you merge the PR?

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837, Vertexwahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)~~ [chases2,michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment