search

bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
291 stars 136 forks source link

refactor: inline some rules_docker 'skylib' helpers #724

Open alexeagle opened 1 year ago

alexeagle commented 1 year ago

Note: I think it might be better to introduce a dep on aspect_bazel_lib instead, which is a very-well maintained utility library that's a superset of bazel_skylib, and evidently rules_docker wished for such a thing as well since it had this folder.

Baby steps towards #723 I'd like to start small and gauge interest from rules_k8s maintainers before spending too much time here.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexeagle Once this PR has been reviewed and has the lgtm label, please assign chizhg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment