bazelbuild / rules_kotlin

Bazel rules for Kotlin
Apache License 2.0
334 stars 210 forks source link

Generated types not visible to IntelliJ #1102

Open cgruber opened 9 months ago

cgruber commented 9 months ago

When running kotlin in IntelliJ, code that is generated in either ksp or kapt processors (e.g. dagger, or custom ksp) are not attached in a way that IJ can see them. They compile, but redline. This also has the effect of making the generated sources un-findable by the IDE.

Related: ksp-generated sources are not visible under bazel-out. kapt-generated sources are, under bazel-bin/path/to/library/_javac/lib/lib-java_tmp/path/to/library/GeneratedFile.java. .kt files generated by KSP are available in the deep directories, but not attached anywhere within bazel-out, so they can't even be navigated to from within the project.

While this is strictly an IntelliJ Bazel plugin issue, it seems to likely be an issue with various aspects and what info attached during rules_kotlin related actions. I'm not sure how to better describe this, but can dig into it with anyone, with examples.

cgruber commented 9 months ago

@restingbull is a comedian

henrikpersson commented 5 months ago

Adding something like this to the BUILD that uses the kt_ksp_plugin "fixed" it for me:

java_plugin(
    name = "convince_intellij_this_module_generates_code",
    srcs = ["Empty.java"],
    generates_api = True,
)
dvpermyakov commented 3 months ago

Bump this thread 😄 Does anyone have a plan to implement this feature?

th0masb commented 3 months ago

Yeah I am encountering this issue trying to use the koin ksp compiler for annotation processing. I have something similar to

kt_ksp_plugin(
    name = "koin_codegen",
    processor_class = "org.koin.compiler.BuilderProcessor",
    deps = [
        "@maven//:io_insert_koin_koin_ksp_compiler_jvm",
    ],
)

kt_jvm_library(
    name = "generated_koin",
    srcs = glob(["src/main/kotlin/**"]),
    plugins = [":koin_codegen"],
    deps = _DEPS,
)

which produces a generated_koin.jar correctly in bazel-bin/path/to/package but Intellij does not add this jar to the external libraries list when another lib adds it as a dep and you cannot use it properly in ij.

TwoClocks commented 1 day ago

I'm stuck on this as well. Have a custom KSP processor that works fine in bazel, but intellij doesn't import the source jar. The KSP plugin is generating the source jar just fine.

Not sure if this is a rules_kotlin problem, or intellij bazel problem.

This can't be "the way it is"? Nobody can see the source for any ksp plugin? That seems kinda crazy. I assume my custom processor isn't doing something it should but I can't figure out what that might be. Especially as it works fine w/ gradle.

@henrikpersson I don't quite understand your fix. Do you add this stub plugin to the target using the ksp plugin? or do you add it to the ksp plugin? Could you give more context/exampels?

henrikpersson commented 20 hours ago

@TwoClocks

I don't remember and trashed the code, but I think it was something like this:

kt_ksp_plugin(
    name = "processor",
    processor_class = "..",
    deps = [
        ":processorimpl",
    ],
)

kt_jvm_library(
    name = "processorimpl",
    resources = ["META-INF/services/com.google.devtools.ksp.processing.SymbolProcessorProvider"],
    exported_plugins = [":convince_intellij_this_module_generates_code"],
    deps = [],
)

java_plugin(    
    name = "convince_intellij_this_module_generates_code",  
    srcs = ["Empty.java"],  
    generates_api = True,   
)

Where Empty.java

class Empty {}