Closed sgowroji closed 7 hours ago
Hm. Interesting. I guess java_common moved.
Will sort it out.
CC @corbinrsmith Any update on the above issue ?
Not yet. From what I can tell rules_kotlin is relying on the rules_java
bzl_library
, which should have the file. Digging into the build graph.
@restingbull Any update?
Passes on MacOS. Debugging on Ubuntu.
Updating bzlmod to 7.6.5 solves it with bzlmod -- still fails on workspace.
The problem appears to be coming from @bazel_tools//tools/build_defs/repo:bzl_srcs
, which is loaded to provide http_archive
, http_file
definitions when generating docs.
export USE_BAZEL_VERSION=880c17c67a9b4e17e9753a5c6e2a759bff5a2cfe; bazel query --enable_bzlmod=false 'allpaths("//kotlin:stardoc", "@rules_java_builtin//toolchains:toolchain_utils.bzl")'
//kotlin:core
//kotlin:core_stardoc
//kotlin:js
//kotlin:js_stardoc
//kotlin:jvm
//kotlin:jvm_stardoc
//kotlin:lint
//kotlin:lint_stardoc
//kotlin:repositories.doc
//kotlin:repositories.doc_stardoc
//kotlin:stardoc
//kotlin/internal:internal
//kotlin/internal/jvm:jvm
//third_party:bzl
@bazel_tools//tools:bzl_srcs
@bazel_tools//tools/jdk:bzl_srcs
@rules_java_builtin//toolchains:bzl_srcs
@rules_java_builtin//toolchains:toolchain_utils.bzl
Adding
bzl_library(
name = "bzl",
srcs = [
"jarjar.bzl",
"@bazel_tools//tools:bzl_srcs",
],
deps = [
"@rules_java_builtin//java/common",
],
)
Fixes it without bzlmod, but breaks it with -- the native java rules rewrite rules_java
to rules_java_builtin
.
Paths forward:
http_archive
/http_file
for doc generation.rules_java_builtin
if runnign with bzlmod.Ah, wrong path. While close (the sources are pulled from bazel_tools
repository), the issue is in importing the jdk toolchain utils, which moved to rules_java
.
Requires bumping rules_java
to 7.6.5, which is not compatible with bazel 6.
@Bencodes / @nkoroste / @oliviernotteghem :
Fixing this will make rules_kotlin
incompatible with java 6.
@Bencodes / @nkoroste / @oliviernotteghem : Fixing this will make
rules_kotlin
incompatible with java 6.
Never mind -- just not using the utility functions turns out to be a better approach.
CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3920#01900fc7-e6cb-4aaa-bf71-2c27285f1a16
Platform: Ubuntu
Logs:
Culprit:
Steps:
CC Greenteam @salmasamy