search

bazelbuild / rules_kotlin

Bazel rules for Kotlin
Apache License 2.0
334 stars 211 forks source link

Update ktlint version #1181

Open ratnikov opened 5 months ago

ratnikov commented 5 months ago

Hey folks,

I noticed that the bundled ktlint version is quite a bit behind the latest (0.49.1 vs 1.3.0) which causes quite a bit of a linting discrepancy. Do you have a suggestion on how I should approach this? Ideas I have so far:

  1. Maybe there's a way to override version in rules_kotlin, though I'm not sure exactly how...
  2. Send a PR to bump the version (that's a bit tricky since my company is still figuring out the CLA process. :( )
  3. Your suggestion here...

Thanks!

Bencodes commented 5 months ago

@ratnikov I put up a PR upgrading the internal version https://github.com/bazelbuild/rules_kotlin/pull/1184

The infrastructure is there to support dynamically setting remote versions via kotlin_repositories, wouldn't be hard to extend that to support KtLint as well. Happy to review a PR for this if you want to take a stab at putting one up!