search

bazelbuild / rules_license

Apache License 2.0
74 stars 26 forks source link

`gather_metadata_info` does not populate the `package_info` field of the returned `TransitiveMetadataInfo` #154

Open shs96c opened 1 week ago

shs96c commented 1 week ago

Expected Behavior

When using the gather_metadata_info aspect, the generated TransitiveMetadataInfo should have all fields populated.

Actual Behavior

Only deps, licenses, and traces are populated.

Steps to Reproduce the Problem

  1. Use the gather_metadata_info aspect on a target
  2. Inspect the returned TransitiveMetadataInfo provider

It looks like the call to the factory method doesn't include a reference to the gathered PackageInfo instances: https://github.com/bazelbuild/rules_license/blob/main/rules/licenses_core.bzl#L204-L210

tonyaiuto commented 1 week ago

Sounds like a bug to me. A perfect thing to look into after vacation

On Wed, Sep 11, 2024, 1:25 PM Simon Stewart @.***> wrote:

Expected Behavior

When using the gather_metadata_info aspect, the generated TransitiveMetadataInfo should have all fields populated. Actual Behavior

Only deps, licenses, and traces are populated. Steps to Reproduce the Problem

  1. Use the gather_metadata_info aspect on a target
  2. Inspect the returned TransitiveMetadataInfo provider

It looks like the call to the factory method doesn't include a reference to the gathered PackageInfo instances: https://github.com/bazelbuild/rules_license/blob/main/rules/licenses_core.bzl#L204-L210

— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_license/issues/154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC22ZWMPPBDFTTHBIB4YHPTZWASBTAVCNFSM6AAAAABOAXW3P6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTSNBWGM4DIMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>