search

bazelbuild / rules_perl

Perl rules for Bazel
Apache License 2.0
25 stars 38 forks source link

Rename workspace to "rules_perl". #20

Closed PiotrSikora closed 3 years ago

PiotrSikora commented 3 years ago

This matches recent changes in other rules.

Signed-off-by: Piotr Sikora piotrsikora@google.com

skeletonkey commented 3 years ago

Looking at other 'rules' projects I see that the naming is a little all over the place, but 'io_bazel_rules_xxx' seems to be used the most (not a full survey though). Is this a new standard or simply what the community is beginning to adopt?

PiotrSikora commented 3 years ago

It's a requirement for github.com/bazelbuild/rules_XXX repos, see: https://docs.bazel.build/versions/master/skylark/deploying.html#workspace

I'm not sure how widely enforced it is, the rules that I interact with the most (https://github.com/bazelbuild/rules_rust, https://github.com/bazelbuild/rules_go, https://github.com/bazelbuild/rules_python, and https://github.com/bazelbuild/rules_foreign_cc) all follow this pattern.

rules_go seems to use a weird hack at import time to allow importing as either rules_go or io_bazel_rules_go, but I think it's an overkill, and rules_rust was renamed very recently, so it was still fresh in my memory, and I assumed that rules_perl is behind, but you're right, it seems that the naming is all over the place, so feel free to ignore this PR.

skeletonkey commented 3 years ago

Thanks for the explanation. I like the standard - especially since it reflects the name of the repository.