Closed aiuto closed 1 year ago
@tetromino was pkg_deb_test one of the rules_pkg things broken at head?
Very strange. Now the tests are failing on mac because of some strange unicode handling of the Description field. Do you know if we changed the python versions on buildkite recently?
I can reproduce this in local testing on my Macbook with Bazel HEAD; everything worked fine with 6.2.1
rules_pkg python code is correct AFAICT.
Something in Bazel at HEAD broke argument encoding in spawned processes on macOS :/
https://github.com/bazelbuild/bazel/issues/18792 - update to JDK 20 broke non-ascii argument encoding on macOS.
I think I should insist you squash these commits into one commit.
I think I should insist you squash these commits into one commit.
That rebase is tricky. It fails on each squashed change and I have to hand edit. The merge squashes it. That is, when I merge things the repo default is squash mode. I edit the comments down to one single one that makes sense. This is the only thing that makes sense. I don't know why other merges are even possible.
Oh... the tests are failing for orthogonal reasons..
I rebased it down. You can't tell in the github UI though.
For me in manual testing, after https://github.com/bazelbuild/bazel/commit/f00439d8b7dd5b10ac357c413928418e0e1059c7, //tests/deb:pkg_deb_test passes on macOS.
But it still fails on the CI machine at the exact same git commit :/
This fixes some subtle problems caused by having CI and developer machines in different time zones. It's also the right thing.