search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
216 stars 174 forks source link

Add basic include_runfiles to pkg_files. #724

Closed aiuto closed 1 year ago

aiuto commented 1 year ago

Show it working in a mappings tests. Improve the mapping test to print something a little more useful.

Next step: Make the same code callable from pkg_tar and pkg_zip

alexeagle commented 1 year ago

@aiuto Now that this has landed, are you planning to start work on the pkg_tar fix, or would you like me to pick that up?

aiuto commented 1 year ago

I'll continue for pkg_tar. I'm going to have to keep importing into google3 to make sure I don't break everyone.

On Wed, Aug 16, 2023 at 11:06 AM Alex Eagle @.***> wrote:

@aiuto https://github.com/aiuto Now that this has landed, are you planning to start work on the pkg_tar fix, or would you like me to pick that up?

— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_pkg/pull/724#issuecomment-1680791537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHHHBVEINU2JXK2HJJSODXVTOXVANCNFSM6AAAAAA3KSRYYU . You are receiving this because you were mentioned.Message ID: @.***>

peakschris commented 11 months ago

Hi @aiuto @alexeagle Thanks for this fix! could you update on this pkg_tar work? And will there be a new release soon that includes the new feature in pkg_files?

aiuto commented 11 months ago

The first of the PRs for that is out for review. I expect to be fully finished by end of October.