Closed aiuto closed 9 months ago
@aiuto what's needed to make this draft Ready for review? We're eager to get this in to fix python images.
The refactoring PR #756 has to go in first. Then I need to rebase on that and add a legacy option. It would also help if #749 were in too, then I can import to Google and test the legacy option. About a day's work, when I get back from vacation.
@aiuto both PRs are merged, is there anything we could do to help with this?
I'm waiting on https://github.com/bazelbuild/rules_pkg/pull/784 so CI can be green again.
On Mon, Nov 20, 2023 at 10:42 AM Diego Ortin @.***> wrote:
@aiuto https://github.com/aiuto both PRs are merged, is there anything we could do to help with this?
— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_pkg/pull/754#issuecomment-1819311287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHHHCZTEFVZURSOGMMSFDYFN263AVCNFSM6AAAAAA44DUYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGMYTCMRYG4 . You are receiving this because you were mentioned.Message ID: @.***>
will this change be pulled into an official release sometime soon? looks like the latest was from may
Now that we are past the bazel 7 release and the holidays it might be time for a new one. It needs a little CI work first to make sure we are testing with bazel 6 (wihout bzlmod) and 7 with both bzlmod and without. Just a matter of an afternoon of grunt work.
On Mon, Jan 1, 2024 at 5:11 PM Connor Latham @.***> wrote:
will this change be pulled into an official release sometime soon? looks like the latest was from may
— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_pkg/pull/754#issuecomment-1873500732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHHHCV67TBH5WWB2JVVQDYMMYAZAVCNFSM6AAAAAA44DUYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGUYDANZTGI . You are receiving this because you modified the open/close state.Message ID: @.***>
Bring tar runfiles up to feature parity with pkg_files.runfiles.
The bulk of the change is to have pkg_tar use
pkg_files%add_label_list
to processsrcs
. That brings it in conformance with pkg_files and pkg_zip. This changes the behavior of runfiles to be useful, but it is a breaking change.Fixes: #153 Fixes: #579
Other bits:
data
file in the sample executable from BUILD to foo.cc so that it is easier to disambiguate from other files.RELNOTES: Improved runfiles support in pkg_tar. Breaking change: we now require a Bazel that supports lambdas.