search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
214 stars 167 forks source link

Don't load cc toolchain from rules_cc #779

Closed meteorcloudy closed 8 months ago

meteorcloudy commented 8 months ago

The cc toolchain autoconfig in rules_cc is out of sync from Bazel and doesn't work with VS2022.

Related: https://github.com/bazelbuild/continuous-integration/pull/1770

meteorcloudy commented 8 months ago

Did rules CC change in a way to believe it is always above 14?

Yes, with Bazel@HEAD, we already switch the default C++ standard to 14: https://github.com/bazelbuild/bazel/pull/18280

We should switch to use centos7_java11_devtoolset10 or just drop this platform.

aiuto commented 8 months ago

We should switch to use centos7_java11_devtoolset10 or just drop this platform. We can't drop centos. We need it for the RPM builder tests.

meteorcloudy commented 8 months ago

We can't drop centos. We need it for the RPM builder tests.

Got it, added in back in .bcr/presubmit.yml