search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
221 stars 174 forks source link

Support make variable substitution in prefix #781

Open criemen opened 11 months ago

criemen commented 11 months ago

Hi,

you're supporting make variable substitution in package_file_name, and custom variables can be supplied via toolchains. That's great! I'm using this to create platform-specific file names. However, in our software, we're also packaging platform-specific files into folders with a platform-specific name. For that, we currently use prefix (of pkg_filegroup) in combination with select. Unfortunately, prefix doesn't support make variable substitution, and therefore we need to have two mechanisms for the same thing. Would it be possible to enable make variable substitution for prefix as well? I've not checked other places, but I assume make variable substitution could also come in handy for renames, and other places where generic file paths are specified.

aiuto commented 11 months ago

It would certainly be possible. It's just a matter of finding time to add it.