Allow substitution of user-defined variables in RPM preamble

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)

Apache License 2.0

214 stars 167 forks source link

Allow substitution of user-defined variables in RPM preamble #787

Closed kellyma2 closed 6 months ago

kellyma2 commented 7 months ago

It's desirable to be able to parameterize some variables in the preamble such as architecture when RPM packages. This change enables variable substitution in the preamble section so that the values may be injected in this fashion in lieu of only using statically defined values.

kellyma2 commented 7 months ago

Will do!

kellyma2 commented 6 months ago

The PR description doesn't seem to match the code at all. It looks like the code just adds some safety against someone mis-typing a variable like $(foo} something (bar) .

The initial PR + first commit match up. When the CI job ran to test the initial changes, it hit the former case that the second commit fixes.