search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
221 stars 174 forks source link

Add %posttrans scriptlet to RPM package #799

Closed k0walik closed 9 months ago

k0walik commented 9 months ago

RPM package specification defines %posttrans scriptlet, which can be particularly useful when upgrading a package. We should add it to the pkg_rpm build rule.

Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#ordering

cgrindel commented 9 months ago

@k0walik #797 just merged disabling the doc builds. I believe that those are causing all/most of the failures in your CI. Could you update your branch with the latest?

k0walik commented 9 months ago
  • I did not notice a test leveraging postrans_scriptlet_file. Could you add one?

Sure! I modified test/rpm/BUILD to test both xxx_scriptlet and xxx_scriptlet_file attributes - it looks like file variant was not tested at all.

  • Could you update your branch with the latest to address the doc_build failures?

Done