Closed kellyma2 closed 4 months ago
i wlll look when i get back from vacation
On Sat, Feb 24, 2024 at 11:32 AM Chuck Grindel @.***> wrote:
@.**** approved this pull request.
This looks good to me. I noticed that CI is failing on Windows. @aiuto https://github.com/aiuto is that a flaky test?
— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_pkg/pull/823#pullrequestreview-1899519262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC22ZWLBKMSTA5YBFDTPRODYVIBYRAVCNFSM6AAAAABDWAXBAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZGUYTSMRWGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
This looks good to me. I noticed that CI is failing on Windows. @aiuto is that a flaky test?
Looks like the failure was in pulling the repo, which I assume to be unrelated to my changes.
Thanks.
This PR does three things:
pkg_rpm()
with no specfile