Improve handling of sub rpms.

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)

Apache License 2.0

212 stars 166 forks source link

Improve handling of sub rpms. #833

Closed aiuto closed 3 months ago

aiuto commented 3 months ago

Do not create the subrpms files when we don't have to
Do not add buildsubdir . That seems to cause rpmbuild failures with older rpmbuild. It generates a cleanup
```
rm -rf . /tmp/tmpXXXXX/BUILD
```
rm chokes on the . and fails.
General cleanup: Remove tests against None which is needlessly brittle. This is a follow to #824. @kellyma2 : Can you test this against your setup to see if the buildsubdir change breaks you?

kellyma2 commented 3 months ago

Will do.

cgrindel commented 3 months ago

FYI. I am waiting to hear back about @kellyma2 testing before hitting approve.

kellyma2 commented 3 months ago

FYI. I am waiting to hear back about @kellyma2 testing before hitting approve.

Sorry, I think I'm ok to merge this, should have been clearer in my comments. I'm away for the week but have done some clearer tests around buildsubdir and how it needs to be used. I'll have a PR when I'm back that covers this a bit better and also includes debuginfo support

aiuto commented 3 months ago

Silly me. Closed without merging. Necromerging now.