search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
221 stars 174 forks source link

Add support for no parent directory inference (#832) #834

Closed eejayes closed 6 months ago

eejayes commented 6 months ago

Add feature as described in #832.

RELNOTES: Automatic creation of parent directory specifications for paths with depth are prevented in pkg_tar archives.

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

eejayes commented 6 months ago

This is a start, intended to solicit early feedback. Existing tests have been merely adapted. New tests have not been added.

eejayes commented 6 months ago

I agree and would have done what you suggested to start with had it been taken into account that the change subject was a Class. And no, I don't see an obvious use case for having fine-grained control of the subject behavior within a target. Let me know if you think the tests suffice. Otherwise I don't intend to add more to them.

eejayes commented 6 months ago

I think this will do for tests. Thanks for the fix.

My pleasure!