When we're using release_file in lieu of release we're just pointing rpmbuild at the file containing the Release string and we don't have it available to inject into the filename resulting in a strange looking filename of the form Foo-version-.arch.rpm.
This change extracts the RPM name generation to a single helper, _make_rpm_filename and tweaks it s.t. if we're missing the value for release we'll just exclude it from the filename format instead.
When we're using
release_filein lieu ofreleasewe're just pointing rpmbuild at the file containing theReleasestring and we don't have it available to inject into the filename resulting in a strange looking filename of the formFoo-version-.arch.rpm.This change extracts the RPM name generation to a single helper,
_make_rpm_filenameand tweaks it s.t. if we're missing the value forreleasewe'll just exclude it from the filename format instead.