search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
212 stars 166 forks source link

Append workspace name to the runfiles directory name for `pkg_files` #864

Closed sitaktif closed 2 months ago

sitaktif commented 2 months ago

This is a follow-up to #856, which applies to most rules but pkg_files uses a different code path. This change applies the fix to pkg_files and adds a test to avoid future regressions.

It also fixes a (silent) bug in the test logic.

sitaktif commented 2 months ago

@aiuto this should probably make it before the next release to avoid confusion.

sitaktif commented 2 months ago

Thanks @cgrindel - I don't have write access so I'll defer merging to you.

cgrindel commented 2 months ago

@aiuto Do you want to look at this before we merge?

sitaktif commented 2 months ago

Thanks!