search

bazelbuild / rules_pkg

Bazel rules for creating packages of many types (zip, tar, deb, rpm, ...)
Apache License 2.0
212 stars 166 forks source link

Provide support for duplicate paths #865

Closed eejayes closed 2 months ago

eejayes commented 2 months ago

Outside of the discussion in the issue #849, there were some unforeseen interactions with create_parents. Otherwise the behavioral change should be what was discussed.

It is outside of the scope to order where the paths from deps or srcs are added to the archives, within a given instance of pkg_tar. It may be worth documenting that controlling the ordering of paths whether they originate from tars which are concatenated or files, requires a sequence of pkg_tar instances rather than relying on a single one. In a way undefined behavior may be expected when adding paths which conflict in the same pkg_tar instance.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

eejayes commented 2 months ago

I can not understand what this change is about from the PR description.

I understand that. I am not so acquainted with the workflow yet. Let's discontinue this PR in favor of https://github.com/bazelbuild/rules_pkg/pull/850 which should now be in good shape.