search

bazelbuild / rules_postcss

PostCSS rules for Bazel
Apache License 2.0
10 stars 13 forks source link

Update rules_nodejs to 5.0.0 #74

Open rzhw opened 3 years ago

rzhw commented 3 years ago

Per https://github.com/bazelbuild/rules_postcss/issues/73#issuecomment-913036877, these rules are incompatible with rules_nodejs 4.0.0 due to the @bazel/worker dep being outdated.

One option is to update to the last 3.x release of @bazel/worker as suggested in https://github.com/bazelbuild/rules_postcss/issues/73#issuecomment-913064525 as that relaxes the rules_nodejs version constraint.

However, absent of a strong reason to avoid doing so, upgrading rules_nodejs, and consequentially @bazel/worker, to the latest version, 4.0.0 should be the approach taken.

alexeagle commented 2 years ago

rules_nodejs 5.0.0 is now out.

@rzhw are you still maintaining this repo?

rzhw commented 2 years ago

Thanks for the heads up.

Unfortunately I've had my hands full and have dropped the ball on this for the time being.

I've done some preliminary work on this, so if I can get the time I'll have a look and put it up if it's a useful start.

alexeagle commented 2 years ago

No worries, I know that rule maintenance is hard to prioritize.

In the meantime, should we give new users some guidance about what's recommended for using postcss with Bazel? Should they just use the generated rule from the postcss npm package rather than this custom ruleset?

rzhw commented 2 years ago

That sounds like a reasonable approach for consistency with other rules_nodejs generated rules, versus the more idiomatic approach taken here.

titanous commented 2 years ago

I've done a lot of this work in #66 and it's working locally (except the wrapper option, because run_node isn't setting up the node_modules properly for the runner when it's not the executable). It's failing in CI, and I've run out of time budget to keep working on this but feel free to keep pushing it forward.