Closed thesayyn closed 1 year ago
quick heads up that I renamed the branch master to main, so you may need to kick this a bit if something goes funny there
Please also fix CI failures.
In case you can't access them, let me know. The failures are:
run the following command in your workspace:<br/><pre><code>buildifier MODULE.bazel WORKSPACE dev_deps.bzl proto/BUILD proto/private/BUILD proto/private/versions.bzl</code></pre>
Please also fix CI failures.
In case you can't access them, let me know. The failures are:
run the following command in your workspace:<br/><pre><code>buildifier MODULE.bazel WORKSPACE dev_deps.bzl proto/BUILD proto/private/BUILD proto/private/versions.bzl</code></pre>
done
Beware that there are tests that depend on protobuf repo. should I remove those as well?
Beware that there are tests that depend on protobuf repo. should I remove those as well?
Could you add a dev dependency to protobuf repo and update the test so that it uses sources?
Could you add a dev dependency to protobuf repo and update the test so that it uses sources?
https://github.com/bazelbuild/rules_proto/pull/181/commits/19dbb3fe7a51c77b812d6c514948222723b39eec can I take this change back then?
Could you add a dev dependency to protobuf repo and update the test so that it uses sources?
19dbb3f can I take this change back then?
Yes, please do. Sorry for the trouble
@comius PTAL.
There's still a buildifier warning, please run
buildifier MODULE.bazel WORKSPACE dev_deps.bzl
Friendly ping.
Please also remove the toplevel BUILD file. I'll create that one in a separate PR, that follow licensing guidelines. (ATM that file breaks copybara)
currently, there are no prebuilt binaries available, it's built from the source using the protobuf workspace. Will add the toolchain for prebuilt binaries in a follow-up
RELNOTES[INC]: protobuf_repo was removed