search

bazelbuild / rules_proto

Protocol buffer rules for Bazel
Apache License 2.0
167 stars 69 forks source link

docs: begin generating docs for defs #186

Closed thesayyn closed 1 year ago

thesayyn commented 1 year ago

i don't know why rules_license is needed all of a sudden...

comius commented 1 year ago

i don't know why rules_license is needed all of a sudden...

Borked up internal setup. I fixed it, however I was waiting for internal review of the fixes. Now they are submitted, rules_proto again pass at head. So you can drop the license related modification.

comius commented 1 year ago

LGTM.

I dislike that the docs/stardoc_with_diff_test.bzl is copied and not public in skylib. But it looks like copying is the best of options.

thesayyn commented 1 year ago

yes, we have that as part of our bazel-lib at aspect, i guess i can't add that as a dev dependency here?

comius commented 1 year ago

yes, we have that as part of our bazel-lib at aspect, i guess i can't add that as a dev dependency here?

No please don't. I'd then need to pull it into google or rewrite it.