search

bazelbuild / rules_proto

Protocol buffer rules for Bazel
Apache License 2.0
167 stars 69 forks source link

feat: introduce toolchain helper #194

Closed thesayyn closed 1 year ago

thesayyn commented 1 year ago

This is not final yet, I just want to test out with rules_python first. Welcome to review though.

Also due to https://github.com/bazelbuild/bazel/issues/20297 i can't write unit tests for the incompatible flag. I'll look for a workaround.

thesayyn commented 1 year ago

I don't mind if some tests are omitted at this level of granularity. Also the code is copied from builtin proto_common.bzl, and already tested there on a slightly bigger granularity (i.e there are tests for proto_library/proto_lang_toolchain/java_proto_library)

hmm, I agree but I still believe we should test this repo with the incompatible flag to be safe even if it's not this granular.

thesayyn commented 1 year ago

@comius I propose adding a new test target to bazelci here that tests the incompatible flag against a prerelease of bazel. i can make that a follow-up

thesayyn commented 1 year ago

@comius PTAL. this is ready.