search

bazelbuild / rules_proto

Protocol buffer rules for Bazel
Apache License 2.0
167 stars 69 forks source link

fix: rules_cc is not a dev_dependency #211

Closed alexeagle closed 6 months ago

alexeagle commented 7 months ago

Since the tools/file_concat program is written in C++ and exposed to users of proto_descriptor_set, we depend on rules_cc at runtime.

Fixes #203

alexeagle commented 7 months ago

Ping @comius

alexeagle commented 6 months ago

ping @comius

comius commented 6 months ago

ping @alexeagle

alexeagle commented 6 months ago

Removed the comment - good to merge now?

keith commented 6 months ago

i missed this one and submitted with lockfile and workspace changes too https://github.com/bazelbuild/rules_proto/pull/215, doesn't matter which is merged but it would be nice to see 1 land

alexeagle commented 6 months ago

@meteorcloudy could you merge please? I'm sad to start the precedent of BCR diverging from the repo it's published from, only because the former has active maintainers with commit access

comius commented 6 months ago

Closing as a duplicate of https://github.com/bazelbuild/rules_proto/pull/215