Open alexeagle opened 1 day ago
Sounds reasonable to me. @aignas -- any concerns/objections?
I could possibly send a PR for it if it's accepted and no one else gets to it.
Accepting *
only as the first or last character in the glob sounds sensible - that way we can have checks of startswith
and endswith
because Starlark does not support regexes. Feel free to submit a PR. :)
Currently
pip_parse
supports a feature to "fix" cycles among third-party packages, for example:However it's difficult to keep this list updated, as it needs to include both direct and transitive dependencies. For example
apache-airflow-providers-common-io
appeared in the locked requirements for one of my clients, and that broke install with a surprising error message.It would be better to write
"airflow": ["apache-airflow-providers-*"]
so that this is robust to whatever providers are installed. https://github.com/aspect-build/rules_js/blob/main/docs/npm_translate_lock.md#list_patches is an example of a similar repo rule in JS-land which supports globs. Note that bazel-lib provides the starlark glob implementation used there.FYI @arrdem