bazelbuild / rules_python

Bazel Python Rules
https://rules-python.readthedocs.io
Apache License 2.0
538 stars 542 forks source link

refactor(pkg_aliases): create a macro for creating whl aliases #2391

Closed aignas closed 1 week ago

aignas commented 2 weeks ago

This just cleans up the code and moves more logic from the repository_rule (i.e. generation of BUILD.bazel files) to loading time (macro evaluation). This makes the unit testing easier and I plan to also move the code that is generating config setting names from filenames to this new macro, but wanted to submit this PR to reduce the review chunks.

Summary:

Related to #260, #2386, #2337, #2319 - hopefully cleaning the code up will make it easier to address those feature requests later.

aignas commented 2 weeks ago

Bazel 9 integration tests are failing - I'll wait for the #2379.