tests: make workspace CI jobs enable workspace mode

bazelbuild / rules_python

Bazel Python Rules

https://rules-python.readthedocs.io

Apache License 2.0

538 stars 542 forks source link

tests: make workspace CI jobs enable workspace mode #2435

Closed comius closed 4 days ago

comius commented 4 days ago

The CI setups claiming to run in WORKSPACE mode were wrong. This fixes it.

Disable integration tests on Windows WORKSPACE mode. They are failing: https://buildkite.com/bazel/rules-python-python/builds/9791#01934eac-3a03-445d-ad53-6683371ca289 Example failure: java.lang.UnsatisfiedLinkError: 'int com.google.devtools.build.lib.windows.WindowsFileOperations.nativeIsSymlinkOrJunction(java.lang.String, boolean[], java.lang.String[])'

rickeylev commented 4 days ago

Oh dang, thanks for noticing that!

I pushed a fix for the integration test failure. Looked like just a difference in case on windows. Also changed the windows CI to not skip the integration tests.

rickeylev commented 4 days ago

I spoke too soon. Most of the //test/integration tests are failing with Windows+workspace with, yeah, that weird JNI linking error. I switched it back to skipping them again, for now.