Apply extra_rustc_flags list to all toolchains

bazelbuild / rules_rust

Rust rules for Bazel

https://bazelbuild.github.io/rules_rust/

Apache License 2.0

623 stars 398 forks source link

Apply extra_rustc_flags list to all toolchains #2693

Closed nmattia closed 2 weeks ago

nmattia commented 2 weeks ago

Fixes #2692

This fixes rust_register_toolchains to correctly call rust_toolchain_repository with a list of extra_rustc_flags.

Previously, the extra_rustc_flags argument of rust_register_toolchains was assumed (when set) to be a dict of toolchain triple to list. With this change, a list parameter is used for all toolchain triples.

nmattia commented 2 weeks ago

I'm a starlark newbie, feedback welcome!