search

bazelbuild / rules_rust

Rust rules for Bazel
https://bazelbuild.github.io/rules_rust/
Apache License 2.0
656 stars 419 forks source link

crate_universe: Don't preform path translation on `out_dir` #2844

Closed konkers closed 2 weeks ago

konkers commented 3 weeks ago

Bug: #2801

krasimirgg commented 2 weeks ago

Thank you! Could you also set up a new presubmit running some of the blzmod examples with --incompatible_use_plus_in_repo_names.

konkers commented 2 weeks ago

Apologies for the noise. Trying to get CI working.

konkers commented 2 weeks ago

OK churn done. I have added tests using --incompatible_use_plus_in_repo_names. This was a bit complicated by the fact that

  1. The command line flag does not exist in the bazel version use by the test by default
  2. The repo names leak into the lock file causing --lockfile_mode=error to fail