Use fake.rs not /dev/null as fake source file

bazelbuild / rules_rust

Rust rules for Bazel

https://bazelbuild.github.io/rules_rust/

Apache License 2.0

670 stars 432 forks source link

Use fake.rs not /dev/null as fake source file #2851

Closed illicitonion closed 2 months ago

illicitonion commented 2 months ago

We store in the lockfile the path of this source file relative to the package, and if we use an absolute path we end up encoding the depth of your local git clone into the lockfile, which is non-determinstic across machines.

Elsewhere we use fake.rs, let's use it here as well.

UebelAndre commented 2 months ago

Thanks! Maybe this is something we should warn users about if it leads to non-reproducible outputs on different machines.

UebelAndre commented 2 months ago

@illicitonion looks like CI failed 😞