search

bazelbuild / rules_rust

Rust rules for Bazel
https://bazelbuild.github.io/rules_rust/
Apache License 2.0
670 stars 433 forks source link

Update Fuchsia triple #2896

Closed jayzhuang closed 1 month ago

jayzhuang commented 1 month ago

... from [aarch64|x86_64]-fuchsia to [aarch64|x86_64]-unknown-fuchsia. The previous one is outdated.

jayzhuang commented 1 month ago

@UebelAndre Please take a look. IIUC the Windows build is failing because of #2878.

I'm not sure about the Bazel version tests that are failing with:

ERROR: error loading package 'external': Both --enable_bzlmod and --enable_workspace are disabled, but one of them must be enabled to fetch external dependencies.

Any ideas?

cc @P1n3appl3

UebelAndre commented 1 month ago

Sorry for the delay here! I made the same change at https://github.com/bazelbuild/rules_rust/pull/2945 which will hopefully merge soon. Gonna close this out in favor of the other PR due to the conflicts.

jayzhuang commented 3 weeks ago

Great, thanks for fixing this, @UebelAndre!