search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 275 forks source link

Diagnostics not working when using scala 2.13.x #1484

Closed crt-31 closed 11 months ago

crt-31 commented 1 year ago

Diagnostics reporting does not seem to be working when using scala 2.13.x (seems to work in 2.12.x though). The diagnostics only show some ‘info’ events, but not any error or warning events.

The issue seems to be in the ProtoReporter, where its using the info0() callback which is deprecated, and instead it should probably use the new doReport() callback. I reviewed the scalac code but I couldn't find why inf0() isn't working in 2.13.x, but I made the simple change to ProtoReporter.java on a fork on my local box and it fixed it.

If this can be validated, can we get this fixed for next release? Thanks.

liucijus commented 1 year ago

@crt-31 thanks for reporting! Would you be willing to contribute your fix with a test?

crt-31 commented 1 year ago

Sure, I'll give it a go. @liucijus, when is the next release scheduled?

liucijus commented 1 year ago

Sure, I'll give it a go. @liucijus, when is the next release scheduled?

@crt-31 we don't have a schedule, but we can do one when there is a fix

aishfenton commented 11 months ago

Still broken in 2.12.18. This time due to DepsReporter having the same issue as above. Pulling together a PR now to address.

(issue should be re-opened though)