search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
360 stars 273 forks source link

Improve scala_config() documentation in README.md #1494

Closed kolotyluk closed 1 year ago

kolotyluk commented 1 year ago

Description

Per https://github.com/bazelbuild/rules_scala/issues/1490 improve README.md

Motivation

As a documentation wonk, I like documentation to minimize mistakes, and following the original documentation led to some copy/paste mistakes that had to be cleared up in the issues.

When I figure out how to support Scala 3, I will update the documentation again with a better explanation.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

kolotyluk commented 1 year ago

CLA has been signed now...

liucijus commented 1 year ago

@googlebot I signed it!

liucijus commented 1 year ago

CLA has been signed now...

Still failing, @kolotyluk could you check if you have signed with the same email as your commits were made?

kolotyluk commented 1 year ago

Google Identity Management is broken. There is no possible way in their UI to correct the information. I will have to contact them.

kolotyluk commented 1 year ago

I spent a fair bit of time with Google One support trying to sort out the problem... Next, follow up with more specialized people at Google...

kolotyluk commented 1 year ago

It seems that Google CLA does not work on Firefox... I have resubmitted via Chrome... Hopefully this works...

kolotyluk commented 1 year ago

Updated CLA with my GitHub identity.