Make DepsTrackingReporter handle Windows path separators

bazelbuild / rules_scala

Scala rules for Bazel

Apache License 2.0

360 stars 273 forks source link

Make DepsTrackingReporter handle Windows path separators #1503

Closed crt-31 closed 1 year ago

crt-31 commented 1 year ago

Description

This fixes issue where the ‘compiler-dependency-analyzer’ was not handling Windows path separator and failed with false negatives.

Added one-liner in DepsTrackingReporter.java that replaces ‘\’ with ‘/’ in the paths it receives from the scalac compiler.

Motivation

Makes the new compiler-dependency-analyzer work on Windows.

Before this PR, on Windows, compiling would report a bunch of erroneous 'unused deps' errors.

This fixes #1487

crt-31 commented 1 year ago

@liucijus, I'm not sure why the CI tests failed on this merge. The tests ran fine on my linux vm. Any chance you could re-run the CI tests on this merge?