search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
359 stars 266 forks source link

Make scala_proto_aspect have "provides = [ScalaProtoAspectInfo]" #1549

Closed timothyg-stripe closed 3 months ago

timothyg-stripe commented 4 months ago

Description

Add provides = [ScalaProtoAspectInfo] to scala_proto_aspect.

Motivation

scala_proto_aspect always returns a ScalaProtoAspectInfo provider, so there's no reason why the provider is not listed in the aspect(provides=[…]) list. Crucially, having provides = [ScalaProtoAspectInfo] enables aspect-on-aspect, allowing a second aspect to inspect the result of scala_proto_aspect.

timothyg-stripe commented 4 months ago

I'm not sure why CI is failing. While I can reproduce the same error locally on a MacBook, I get the same errors on the current master branch.