search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 275 forks source link

fix typo in example tests (Exmaple => Example) #1553

Closed KevinBoyette closed 6 months ago

KevinBoyette commented 6 months ago

Description

I was grepping through and found some examples that had the same typo.

Motivation

I found a typo and wanted to help out.

KevinBoyette commented 6 months ago

Anytime! @liucijus! I'd love to help out more. For now, I'm trying to dig into these build failures.

liucijus commented 6 months ago

Anytime! @liucijus! I'd love to help out more. For now, I'm trying to dig into these build failures.

Failures must be caused by default JDK update on CI (unrelated to your changes). There's a Rules Scala issue https://github.com/bazelbuild/rules_scala/issues/1521.

KevinBoyette commented 6 months ago

Good to know that it's not these changes that are breaking the build. I see that there's discussion around --jvmopt=-Djava.security.manager=allow.

I also see Junit4 in the error message. I'm not an expert in this space, but would an upgrade to Junit5 be worth considering? I don't see that as being a trivial change from what I can find on the internet.

KevinBoyette commented 6 months ago

Thank you for approving!