search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 275 forks source link

Handle the removal of to_proto and to_json from struct #1554

Closed c-mita closed 6 months ago

c-mita commented 6 months ago

Check that the names exist before trying to remove them from the list of fields on a struct.

These methods do not exist if --incompatible_struct_has_no_methods is passed or if they have been removed in a future version of Bazel.

c-mita commented 6 months ago

Test failures appear unrelated to my changes.

sgowroji commented 6 months ago

Can we make a new release with this change to unblock migrating other projects https://github.com/bazelbuild/rules_webtesting/issues/475#issuecomment-2011902869 
https://github.com/bazelbuild/rules_jvm_external/issues/1080 /cc @c-mita @meteorcloudy

simuons commented 5 months ago

Hi, @sgowroji, just made a new release including this change https://github.com/bazelbuild/rules_scala/releases/tag/v6.5.0