Use version-aware naming for `scala_compiler_source` repository

bazelbuild / rules_scala

Scala rules for Bazel

Apache License 2.0

359 stars 266 forks source link

Use version-aware naming for `scala_compiler_source` repository #1560

Closed aszady closed 3 months ago

aszady commented 3 months ago

Description

A small preparation for multiple SCALA_VERSIONS.

In theory breaking, as removes @scala_compiler_source repository. But I guess it's too internal to anyone depend on it.

Motivation

Originally #1290. Partitioned from #1552.

aszady commented 3 months ago

Hi @simuons, @liucijus, can we do anything to help you reviewing these PRs regarding cross-build support? Note that all open PRs are independent of each other and could be reviewed/merged in any order.

simuons commented 3 months ago

Hi @aszady, sorry last week I was on vacation and could not get over your PRs. I'm looking at them now and will answer today/tomorrow.

simuons commented 3 months ago

Hi, @aszady, could you confirm this is still relevant? I mean in another PR you mentioned that direction you are taking is to have single label with select. This doesn't apply here?

aszady commented 3 months ago

Yes; I think the general convention should be like:

for repositories, that actually need to download something (artifacts, see: #1562; or here the compiler source) – use individual repository names with the suffix;
for targets, that are usually built (e.g. majority of #1564) – distinguish them by configurations + select.

Toolchains with config transitions seem to nicely join these two worlds together.