bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
359 stars 266 forks source link

Propagate maven_coordinates tag to generated scala_import so pom generation includes the dependency #1568

Closed vinnybod closed 2 months ago

vinnybod commented 3 months ago

Description

Add a maven_coordinates= tag to the generated scala maven dependency targets.

Motivation

rules_jvm_external pom generation uses the maven_coordinates=x:y:z tag to determine the formatting of a dependency in the pom. Because this tag is missing, the scala dependencies are excluded from the generated pom. I need for example @io_bazel_rules_scala_scala_library//jar to appear in my generated pom as

<dependency>
    <groupId>org.scala-lang</groupId>
    <artifactId>scala-library</artifactId>
    <version>2.13.12</version>
</dependency>
google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

vinnybod commented 3 months ago

Still figuring out who in my company needs to deal with the CLA, but would love some feedback on this in the meantime.

liucijus commented 3 months ago

@vinnybod to get this merged, CLA needs to be signed

vinnybod commented 2 months ago

@liucijus CLA was signed and submitted yesterday. It was a corporate CLA, so according to opensource.google/documentation/reference/cla#cla-accepted , it might take a couple days for it to process.

vinnybod commented 2 months ago

CLA is approved