Open evis opened 5 months ago
Also, strict_deps_mode = error
sometimes suggests to add proto_library() dependencies, instead of java_proto_library() dependencies. Couldn't create MVCE yet, though.
Hi, @evis! Thanks for reporting. Could you create a small repo to reproduce your problem?
Regarding java_proto_library
deps being incorrectly reported - it's a known issue. It happens because the archive is stamped with incorrect target label from the aspect. The similar issue for scala_proto_library
is here for more info: https://github.com/bazelbuild/rules_scala/issues/1234#issuecomment-791628830
Regarding java_proto_library deps being incorrectly reported - it's a known issue
Thanks for your link, found https://github.com/bazelbuild/bazel/issues/4990 here
Could you create a small repo to reproduce your problem?
Yes, I'll try
I tried to turn on
strict_deps_mode = "error"
in myscala_toolchain()
, but it complains about dependencies that aren't used directly in my Scala code.BUILD
:model.proto
:ScalaClass.scala
:Expected bazel build result: success (it builds with
strict_deps_mode = "off"
).Actual bazel build result: fails with
It's kind of surprising, since protobuf//java isn't used explicitly in my Scala code, it's used transitively via ProtoEnum.
Moreover, if I run all of given buildozer commands, then build fails again:
Although, if I just do
buildozer 'add deps @@com_google_protobuf//java/core:core' //deps-mode:scala_class
, then build succeeds. But I'd like to avoid adding this dependency everywhere.