bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 278 forks source link

Transfer rules_scala to bazel-contrib #1616

Open meteorcloudy opened 2 months ago

meteorcloudy commented 2 months ago

Description:

This issue proposes transferring the rules_scala repository from the bazelbuild GitHub organization to the bazel-contrib GitHub organization, which is owned by the Community for Bazel project under the Linux Foundation.

GitHub Discussion: https://github.com/orgs/bazelbuild/discussions/2

Impacts:

Read more on Transferring a repository from GitHub documentation.

Checklist:

alexeagle commented 2 months ago

Notes from SIG meeting: this transfer was unanimously approved by a thumbs-up vote.

simuons commented 2 months ago

Approve. Thanks.

liucijus commented 2 months ago

👍🏻

meteorcloudy commented 2 months ago

Thanks for the approvals, I'll initiate the transfer now.

meteorcloudy commented 2 months ago

Just noticed rules_scala doesn't support Bzlmod yet, is that going to be a blocker? @alexeagle

See 9 from https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html#adding-criteria

alexeagle commented 2 months ago

Yes, thank you - we ought to hold off on this one in that case.

Of course it's just as feasible to fix for bzlmod after the transfer, but I think the SIG would like to know who is committed to doing that work.

meteorcloudy commented 2 months ago

Agree, it's better to clarify that since we are disabling WORKSPACE in Bazel 8.

meteorcloudy commented 2 months ago

Essentially blocking on https://github.com/bazelbuild/rules_scala/pull/1595

@liucijus @simuons Any plan to review and accept that PR?

simuons commented 1 month ago

@meteorcloudy I don't think that PR is complete. I'll be able to look at this next week.

mbland commented 1 month ago

BTW, I've just posted my willingness to contribute to Bzlmodification in https://github.com/bazelbuild/rules_scala/issues/1482#issuecomment-2389248501, if folks are cool with that. As stated there, I've a (mostly) working branch already.

simuons commented 1 month ago

Hi, @mbland, if you could take this that would be awesome. I promised to look at it a week ago but couldn't. So any help here would be greatly appreciated.

mbland commented 1 month ago

@simuons My pleasure! I'm very close to having the bzlmod branch in my fork passing ./test_all.sh. I'll be carving off other independent pieces shortly.

A question regarding Bazel 6 support: I'm making sure my changes are still compatible with Bazel 6 and WORKSPACE, but I've also got them working with the latest Bazel 7. I don't have a strong opinion, but I'm curious which of the following options sound good to you:

mbland commented 1 month ago

FYI, a brief status update: https://github.com/bazelbuild/rules_scala/issues/1482#issuecomment-2407784993

Basically, I'm very close to being done with my first draft, and anticipate sending more pull requests soon.

meteorcloudy commented 1 month ago

/cc @romanowski, @lukaszwawrzyk from VirtusLab, who are also very interested in helping rules_scala development.

simuons commented 1 month ago

Hi, @mbland, answering "regarding Bazel 6 support: ". I think we should use third option. Keep bazel 6 until bzlmod is supported. Once bzlmod is ready we will make bazel 6 release and switch to bazel 7. Does this sound good to you?

mbland commented 1 month ago

@simuons Sounds good to me!