search

bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 278 forks source link

Make scala_xxx rules declare that they provide JavaInfo #1643

Closed crt-31 closed 1 week ago

crt-31 commented 2 weeks ago

Description

Made most scala_xxxx rules declare that they provide JavaInfo (setting the "provides" attribute). This allows these targets to be visited by aspects that use "required_providers=[JavaInfo]".

This matches behavior in java_xxx rules, and goal was to address all the equivelant scala_xxx rules.

rules updated are: scala_import, scala_library, scala_binary, scala_test, scala_junit_test, scala_proto, and scala_repl. (scala_proto_library was already correct).

Motivation

Allows scala_xxx rules to be visited by aspects that use "required_providers=[JavaInfo]"

google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mbland commented 2 weeks ago

Looks like you need to run bazel run //tools:lint_fix. Got me on my first few PRs, too.